Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 3 | Implement and rewrite tests by mshayriyesaricicek · Pull Request #1266 · CodeYourFuture/Module-Structuring-and-Testing-Data

mshayriyesaricicek · 2026-03-14T12:46:41Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This pull request practices implementing assertions and the use of Jest.

The functIon are written initially with assertions then re-written using jest.

mshayriyesaricicek · 2026-03-14T15:27:48Z

I've tried reverting but it got very messy with GPT so in the end I made a new branch so that it was clean and not on main.
In Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js I added the other boundary test.
In Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js I grouped the tests together as you suggested.
I have closed the previous pull request Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 3 | Implement and rewrite tests
#1230

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

cjyuan

This PR does not yet have a "Needs Review" label.
I assume you are still working on fixing 3-get-card-value.js based on the suggestions you wrote in the comment.

Note: You might have accidently changed the labels in another PR instead of this one.

cjyuan · 2026-03-15T23:51:14Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

  expect(getAngleType(1)).toEqual("Acute angle");
  expect(getAngleType(45)).toEqual("Acute angle");
  expect(getAngleType(89)).toEqual("Acute angle");
+  expect(getAngleType(91)).toEqual("Obtuse angle");


Since 91 is checked in case 3, it is optional to check it in this group.

Note: To express, "91 should not be considered as Acute angle", in Jest we could write:
expect(getAngleType(91)).not.toEqual("Acute angle");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

cjyuan · 2026-03-16T19:10:47Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  if (card.startsWith("10")) {
+    firstChar = "10";
+    suit = card[2]; //if it starts with 10 the third character is the suit
+  } else {
+    firstChar = card[0]; //otherwise
+    suit = card[1]; //the second character is the suit
+  }


Can you test your function with these invalid cases?

getCardValue("2♥2"); getCardValue("2♥♥");

I have amended it to include these as invalid cases too.

cjyuan · 2026-03-18T23:14:16Z

The new implementation works (even though its logic is a bit complicated). Here is an approach for you to review:

// Step 1: Extract `rank` and `suit` from `card`. (We can use `.slice()` to extract each part)

// Step 2: Check if `rank` is one of the 13 possible string values and `suit` is one of the 4 possible characters.

// If the code pass all the checks, then we only need to deal with valid rank from this point onward.
...

cjyuan · 2026-03-18T23:17:15Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

+  expect(getAngleType(181)).toEqual("Reflex angle");
+  expect(getAngleType(270)).toEqual("Reflex angle");
+  expect(getAngleType(359)).toEqual("Reflex angle");
+  expect(getAngleType(360))not.toEqual("Reflex angle")


Typo on line 43.

Doesn't VSCode show .js file with syntax errors in red color?

mshayriyesaricicek added 7 commits March 5, 2026 09:52

Update .gitignore to include .vscode directory

32407f9

Add Implement and Rewrite Test files only

01ca25c

Update 1-get-angle-type.test.js with new lines

77ebe17

Fix test case for proper fraction

1af10d6

Fix test case for isProperFraction() with zero numerator

2deb27e

Updated test for proper fraction

01b8b9c

Grouped tests together

eaaccca

mshayriyesaricicek force-pushed the implement-rewrite-tests-clean branch from 7bec493 to eaaccca Compare March 14, 2026 15:16

mshayriyesaricicek added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Mar 14, 2026

mshayriyesaricicek mentioned this pull request Mar 14, 2026

Sheffield | ITP-Jan-26 | Structuring and Testing Data | Hayriye Saricicek | mshayriyesaricicek/My-Coursework-Planner#101

Open

cjyuan reviewed Mar 15, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 15, 2026

mshayriyesaricicek added 3 commits March 15, 2026 20:30

updated to include angle-0

23b24d4

made descriptions more concise and added tests for negative numbers

39e1bfc

amended case 5 to exclude 360

126aa36

cjyuan reviewed Mar 16, 2026

View reviewed changes

amended to check second character

767fe59

cjyuan reviewed Mar 16, 2026

View reviewed changes

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js Outdated Show resolved Hide resolved

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js Show resolved Hide resolved

mshayriyesaricicek added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 16, 2026

cjyuan reviewed Mar 16, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 16, 2026

mshayriyesaricicek added 2 commits March 18, 2026 22:51

added extra invalid tests, changed if statements

2a7ca83

amended names to not.toEqual and signing for line 39

9bf2f4d

mshayriyesaricicek added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 18, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 18, 2026

cjyuan reviewed Mar 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 3 | Implement and rewrite tests#1266

Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 3 | Implement and rewrite tests#1266
mshayriyesaricicek wants to merge 13 commits intoCodeYourFuture:mainfrom
mshayriyesaricicek:implement-rewrite-tests-clean

mshayriyesaricicek commented Mar 14, 2026

Uh oh!

mshayriyesaricicek commented Mar 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan left a comment •

edited

Loading

Uh oh!

cjyuan Mar 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Mar 16, 2026 •

edited

Loading

Uh oh!

mshayriyesaricicek Mar 18, 2026

Uh oh!

cjyuan commented Mar 18, 2026

Uh oh!

cjyuan Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mshayriyesaricicek commented Mar 14, 2026

Changelist

Uh oh!

mshayriyesaricicek commented Mar 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshayriyesaricicek Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Mar 18, 2026

Uh oh!

cjyuan Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cjyuan left a comment •

edited

Loading

cjyuan Mar 16, 2026 •

edited

Loading